Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

399 new group registrations shouldnt go to holding page #436

Merged

Conversation

camilovegag
Copy link
Collaborator

Closes: #399

@camilovegag camilovegag added the berlin berlin webapp label May 8, 2024
@camilovegag camilovegag self-assigned this May 8, 2024
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
core ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 2:36pm
forum-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 2:36pm

Copy link
Contributor

@diegoalzate diegoalzate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does what it says it will do. next questions would be:

  1. what do we want it to do?
  2. also fix the group registration bug where group registrations overwrite a user registrations

but these questions can be handled in a different pr

@camilovegag camilovegag merged commit ccad72a into develop May 8, 2024
5 checks passed
@camilovegag camilovegag deleted the 399-new-group-registrations-shouldnt-go-to-holding-page branch May 8, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
berlin berlin webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New group registrations shouldn't go to holding page
2 participants